Unconditionally capture tokens for attributes.#77255
Merged
bors merged 4 commits intorust-lang:masterfrom Oct 24, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to avoid synthesizing tokens in
prepend_attr, since wehave the original tokens available.
We still need to synthesize tokens when expanding
cfg_attr,but this is an unavoidable consequence of the syntax of
cfg_attr-the user does not supply the
#and[]tokens that acfg_attrexpands to.
This is based on PR #77250 - this PR exposes a bug in the current
collect_tokensimplementation, which is fixed by the rewrite.